-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Remove blue bar #4616
Draft
jon-kirwan
wants to merge
8
commits into
main
Choose a base branch
from
remove-blue-bar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To set `border-bottom: none`.
Used by Service manual / tookit pages
Including blue_bar (passed in from Static) blue_bar_dedupe hack blue_bar_background_colour blue_bar_wrapper_classes
Changes added here #3380 but no longer needed since blue bar will be removed. Also will require changes in Collections.
053f8b3
to
d2c4b89
Compare
This was referenced Feb 7, 2025
a837bb3
to
bafb625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove various 'blue bar' configurations
https://trello.com/c/3EkNY2Bs/3254-prepare-a-pr-to-turn-off-the-blue-border-at-the-bottom-of-the-header?filter=label:Frontend%20devs
https://trello.com/c/9kohZAvu/3347-remove-support-for-the-blue-bar-below-the-header
Why
The blue bar beneath the current black header on GOV.UK pages is applied by https://github.com/alphagov/govuk_publishing_components. We want to remove the blue bar and we will need to update the gem accordingly. However the blue bar code is very old and complicated and we’re not sure how best to do it.
Visual Changes
Before
After
Anything else
alphagov/collections#3976
alphagov/frontend#4627
alphagov/static#3578