Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Remove blue bar #4616

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Remove blue bar #4616

wants to merge 8 commits into from

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Feb 6, 2025

What

Remove various 'blue bar' configurations

https://trello.com/c/3EkNY2Bs/3254-prepare-a-pr-to-turn-off-the-blue-border-at-the-bottom-of-the-header?filter=label:Frontend%20devs

https://trello.com/c/9kohZAvu/3347-remove-support-for-the-blue-bar-below-the-header

Why

The blue bar beneath the current black header on GOV.UK pages is applied by https://github.com/alphagov/govuk_publishing_components. We want to remove the blue bar and we will need to update the gem accordingly. However the blue bar code is very old and complicated and we’re not sure how best to do it.

Visual Changes

Before

After

Anything else

alphagov/collections#3976
alphagov/frontend#4627
alphagov/static#3578

Used by Service manual / tookit pages
Including blue_bar (passed in from Static)
blue_bar_dedupe hack
blue_bar_background_colour
blue_bar_wrapper_classes
Changes added here #3380 but no longer needed since blue bar will be removed.
Also will require changes in Collections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants