Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component wrapper to contextual guidance component #4277

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add component wrapper to contextual guidance component #4277

merged 1 commit into from
Oct 4, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Oct 3, 2024 •
edited
Loading

What / Why

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4277 October 3, 2024 10:56 Inactive
@AshGDS AshGDS force-pushed the contextual-guidance-component-wrapper branch from fffa1fe to a291962 Compare October 3, 2024 11:02
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4277 October 3, 2024 11:02 Inactive
@AshGDS AshGDS force-pushed the contextual-guidance-component-wrapper branch from a291962 to f22886f Compare October 3, 2024 11:10
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4277 October 3, 2024 11:10 Inactive
@AshGDS AshGDS self-assigned this Oct 3, 2024
@AshGDS AshGDS marked this pull request as ready for review October 3, 2024 11:21
@AshGDS AshGDS requested a review from andysellick October 3, 2024 11:21
andysellick
andysellick approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to ask if there were any tests that needed removing, but I'm startled to note that this component didn't have any for testing the passing of data attributes 😢

@AshGDS AshGDS merged commit 9238cec into main Oct 4, 2024
12 checks passed
@AshGDS AshGDS deleted the contextual-guidance-component-wrapper branch October 4, 2024 09:20
@MartinJJones MartinJJones mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci