Add more aria attributes to the buttons

This should help make it clearer to screen readers what the buttons are for.
alphagov · Nov 8, 2018 · a6fd25a · a6fd25a
1 parent 0a5cd50
commit a6fd25a
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/app/views/govuk_publishing_components/components/_feedback.html.erb b/app/views/govuk_publishing_components/components/_feedback.html.erb
@@ -18,10 +18,11 @@
           'track-category' => 'yesNoFeedbackForm',
           'track-action' => 'ffMaybeClick'
         },
+        'aria-expanded': false,
+        role: 'button',
         style: 'display: none;',
         hidden: 'hidden',
         'aria-hidden': 'true',
-        'aria-expanded': false,
       } do %>
         Maybe
       <% end %>
@@ -31,35 +32,37 @@
         data: {
           'track-category' => 'yesNoFeedbackForm',
           'track-action' => 'ffYesClick'
-          },
-        } do %>
-          Yes <span class="visually-hidden">this page is useful</span>
+        },
+        'aria-expanded': false,
+        role: 'button',
+      } do %>
+        Yes <span class="visually-hidden">this page is useful</span>
       <% end %>
 
       <%= link_to contact_govuk_path, {
         class: 'gem-c-feedback__prompt-link js-toggle-form js-page-is-not-useful',
         data: {
           'track-category' => 'yesNoFeedbackForm',
           'track-action' => 'ffNoClick'
-          },
-          'aria-controls': 'page-is-not-useful',
-          'aria-expanded': false,
-          'role': 'button'
-        } do %>
-          No <span class="visually-hidden">this page is not useful</span>
+        },
+        'aria-controls': 'page-is-not-useful',
+        'aria-expanded': false,
+        role: 'button',
+      } do %>
+        No <span class="visually-hidden">this page is not useful</span>
       <% end %>
 
       <%= link_to contact_govuk_path, {
         class: 'gem-c-feedback__prompt-link gem-c-feedback__prompt-link--wrong js-toggle-form js-something-is-wrong',
         data: {
           'track-category' => 'Onsite Feedback',
           'track-action' => 'GOV.UK Open Form'
-          },
-          'aria-controls': 'something-is-wrong',
-          'aria-expanded': false,
-          'role': 'button'
-        } do %>
-          Is there anything wrong with this page?
+        },
+        'aria-controls': 'something-is-wrong',
+        'aria-expanded': false,
+        role: 'button',
+      } do %>
+        Is there anything wrong with this page?
       <% end %>
     </div>