Stop installing govuk-prototype-kit globally in tests #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-no-install-g
branch
2 times, most recently
from
a88fd2d to
9d0fabf
Compare
We don't want to accidentally end up with development code installed in system Node installation after running tests.
lfdebrux
force-pushed
the
ldeb-no-install-g
branch
from
9d0fabf to
ef4e541
Compare
- log test directory - echo to stderr - no need to create directory for create script - run in repo dir instead of test dir - use remove instead of rmdir to avoid deprecation warnings - use writeJson to simplify creating tracking config
lfdebrux
force-pushed
the
ldeb-no-install-g
branch
from
bd14184 to
bd803ad
Compare
On Windows if given an absolute path starting with drive `create` would error with `Path contains invalid characters`.
nataliecarey
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to accidentally end up with development code installed in system Node installation after running tests.