Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publishing docs #486

Merged
merged 3 commits into from
Feb 1, 2018
Merged

Update publishing docs #486

merged 3 commits into from
Feb 1, 2018

Conversation

hannalaakso
Copy link
Member

This PR:

  • Removes the documentation around manual testing after running build:packages as we have now automated tests to cover this 🎉
  • Adds a note about where the automated tests live
  • Fixes some indentation issues

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-486 January 30, 2018 15:01 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-486 January 30, 2018 15:02 Inactive
@hannalaakso hannalaakso force-pushed the update-publishing-docs2 branch from d3d8d8c to 84cb217 Compare January 30, 2018 15:04
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-486 January 30, 2018 15:04 Inactive
CHANGELOG.md Outdated
@@ -38,6 +38,7 @@ Internal:
- Add tests for breadcrumbs component (PR [#461](https://github.com/alphagov/govuk-frontend/pull/461))
- Add tests for details component (PR [#480](https://github.com/alphagov/govuk-frontend/pull/480))
- Add tests for warning text component (PR [#479](https://github.com/alphagov/govuk-frontend/pull/479))
- Add tests for warning text component (PR [#479](https://github.com/alphagov/govuk-frontend/pull/479))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an accidental addition

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍 Removed.

Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@hannalaakso hannalaakso merged commit ca44b86 into master Feb 1, 2018
@hannalaakso hannalaakso deleted the update-publishing-docs2 branch February 1, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants