-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump husky from 8.0.3 to 9.0.10 #4714
Conversation
Bumps [husky](https://github.com/typicode/husky) from 8.0.3 to 9.0.10. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v8.0.3...v9.0.10) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
We’ve chosen to patch their previous approach since it nicely suppresses errors when installing for production only
@romaricpascal Linking #4691 (comment) and #4691 (comment) for context Shall we pick their default -"prepare": "node -e \"try { require('husky').install() } catch (e) {if (e.code !== 'MODULE_NOT_FOUND') throw e}\""
+"prepare": "node -e \"try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }\" --input-type module" I've pushed this example up, happy to approve Update: Done the same in alphagov/govuk-design-system#3514 |
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for dd2ea40 |
I'd be keen to patch the prepare to load the module, to keep avoiding the 'command not found' being logged that they mention in their docs when using I'd have thought we could do without the |
☝️ Let me know if you're happy with me patching
Snap, except it's similar to why Jest can't run ES modules without a flag > prepare
> node -e "try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }"
[eval]:1
try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }
^^^^^^
SyntaxError: Unexpected token 'import'
at makeContextifyScript (node:internal/vm:123:14)
at node:internal/process/execution:98:22
at [eval]-wrapper:6:24
at runScript (node:internal/process/execution:92:62)
at evalScript (node:internal/process/execution:123:10)
at node:internal/main/eval_string:51:3
Node.js v20.10.0 |
Bumps husky from 8.0.3 to 9.0.10.
Release notes
Sourced from husky's releases.
... (truncated)
Commits
c042d9b
9.0.10e529368
fix: rename index.d.ts to index.d.mts (#1379)6219cac
9.0.9d8377fe
refactor: rename files (#1378)211b80a
9.0.8a5a45fc
refactor: reduce file size (#1377)d091328
fix: tab detection on install command (#1376)798f1ad
docs: update listb98985d
test: expect init to exit with 03e13656
docs: fix linksDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)