Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump husky from 8.0.3 to 9.0.10 #4714

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 2, 2024

Bumps husky from 8.0.3 to 9.0.10.

Release notes

Sourced from husky's releases.

v9.0.10

v9.0.9

v9.0.8

v9.0.7

v9.0.6

v9.0.5

v9.0.4

v9.0.3

v9.0.2

v9.0.1

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [husky](https://github.com/typicode/husky) from 8.0.3 to 9.0.10.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v8.0.3...v9.0.10)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Feb 2, 2024
@dependabot dependabot bot requested a review from a team February 2, 2024 09:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4714 February 2, 2024 09:29 Inactive
We’ve chosen to patch their previous approach since it nicely suppresses errors when installing for production only
@colinrotherham
Copy link
Contributor

colinrotherham commented Feb 2, 2024

@romaricpascal Linking #4691 (comment) and #4691 (comment) for context

Shall we pick their default husky | true or patch their old "prepare" script with --input-type module?

-"prepare": "node -e \"try { require('husky').install() } catch (e) {if (e.code !== 'MODULE_NOT_FOUND') throw e}\""
+"prepare": "node -e \"try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }\" --input-type module"

I've pushed this example up, happy to approve

Update: Done the same in alphagov/govuk-design-system#3514

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4714 February 2, 2024 09:50 Inactive
Copy link

github-actions bot commented Feb 2, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.45 KiB
dist/govuk-frontend-development.min.js 38.58 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.74 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.99 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.44 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.57 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 70.32 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.57 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 4.46 KiB
components/notification-banner/notification-banner.mjs 4.93 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.39 KiB
components/tabs/tabs.mjs 10.16 KiB

View stats and visualisations on the review app


Action run for dd2ea40

@romaricpascal
Copy link
Member

I'd be keen to patch the prepare to load the module, to keep avoiding the 'command not found' being logged that they mention in their docs when using husky || true.

I'd have thought we could do without the --input-type module as import() is available in CommonJS files and uses the ECMAScript module loader. Not a blocker, though 😊

@colinrotherham
Copy link
Contributor

I'd be keen to patch the prepare to load the module, to keep avoiding the 'command not found' being logged that they mention in their docs when using husky || true.

☝️ Let me know if you're happy with me patching prepare in #4714 (comment)

I'd have thought we could do without the --input-type module as import() is available in CommonJS files and uses the ECMAScript module loader. Not a blocker, though 😊

Snap, except it's similar to why Jest can't run ES modules without a flag

> prepare
> node -e "try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }"

[eval]:1
try { (await import('husky')).default() } catch (e) { if (e.code !== 'ERR_MODULE_NOT_FOUND') throw e }
             ^^^^^^

SyntaxError: Unexpected token 'import'
    at makeContextifyScript (node:internal/vm:123:14)
    at node:internal/process/execution:98:22
    at [eval]-wrapper:6:24
    at runScript (node:internal/process/execution:92:62)
    at evalScript (node:internal/process/execution:123:10)
    at node:internal/main/eval_string:51:3

Node.js v20.10.0

@colinrotherham colinrotherham merged commit f1060b6 into main Feb 2, 2024
45 checks passed
@colinrotherham colinrotherham deleted the dependabot/npm_and_yarn/husky-9.0.10 branch February 2, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
Development

Successfully merging this pull request may close these issues.

3 participants