Error if responsive mixins don't get a map #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-447
Add validation to the responsive spacing and typography mixins that expects maps, and errors if a user incorrectly passes in another value (for example, a value from the non-responsive spacing scale)
36degrees
force-pushed
the
warn-using-wrong-mixins
branch
from
7685a5a to
b1b9ae6
Compare
|
Epic 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation to the responsive spacing and typography mixins that expects maps, and errors if a user incorrectly passes in another value (for example, a value from the non-responsive spacing scale)
GitHub and Sublime Text are both struggling to correctly syntax-highlight
@errorcalls for some reason, but it does work…https://trello.com/c/OjWgpYkt/463-throw-errors-when-fe-spacing-mixins-used-wrong