-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build tasks: Rename compile
to build:app
#3371
Conversation
c09f441
to
08431a8
Compare
62c7273
to
e9dc491
Compare
bbb70de
to
94ae8ec
Compare
e9dc491
to
9192bbd
Compare
94ae8ec
to
01f19fb
Compare
9192bbd
to
b8a552a
Compare
01f19fb
to
1039b99
Compare
b8a552a
to
9643234
Compare
9643234
to
3a5b346
Compare
3a5b346
to
8cbd395
Compare
1039b99
to
d4db145
Compare
8cbd395
to
fe3f653
Compare
d4db145
to
f14899f
Compare
fe3f653
to
bfff3e5
Compare
bfff3e5
to
8f53517
Compare
8f53517
to
887f584
Compare
compile
to build:public
compile
to build:app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, bar one minor comment on some of the docs changes
docs/contributing/tasks.md
Outdated
- run sub tasks from `gulp styles` without ESLint code quality checks | ||
- run sub tasks from `gulp scripts` without StyleLint code quality checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the wrong way round?
- run sub tasks from `gulp styles` without ESLint code quality checks | |
- run sub tasks from `gulp scripts` without StyleLint code quality checks | |
- run sub tasks from `gulp styles` without StyleLint code quality checks | |
- run sub tasks from `gulp scripts` without ESLint code quality checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@36degrees Well spotted, they've been switched since 4c11f65 🤦♂️
✅ Fixed
887f584
to
a34749b
Compare
Helps reduce duplication in `gulpfile.mjs` once we start to move directory and file path configs over
a34749b
to
57868c4
Compare
We've planned to remove
--destination
flag to simplify our build tasks in:But we currently have one build script that has some overlap:
Surprise: The
compile
task is also run onbuild:dist
and unnecessarily generates documentationChanges
This PR does three things:
compile
task tobuild:app
(the review app)build:compile
script tobuild:app
build:dist
from building JSDoc and SassDocThis lines up all our tasks so we can remove
--destination
in futureBefore
npx gulp compile
After
npx gulp build:app --destination "public"