-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to del
and slash
"ESM only" packages
#2984
Conversation
fcfc213
to
0b031ee
Compare
4343e20
to
42f81c4
Compare
42f81c4
to
b70a84c
Compare
d7bf7cd
to
fb1de88
Compare
b70a84c
to
f44c73e
Compare
fb1de88
to
c30ddb4
Compare
f44c73e
to
8f89261
Compare
c30ddb4
to
4d7cf6c
Compare
8f89261
to
f7cd22c
Compare
4d7cf6c
to
04638b8
Compare
f7cd22c
to
57cf083
Compare
b6f06dd
to
39d7329
Compare
57cf083
to
0751bb8
Compare
0751bb8
to
be1e33d
Compare
Going to make this ready for review as we've discussed it this morning Likely due to a recent Jest or Babel package update (or the Node.js 18 upgrade) we no longer need to include child packages in |
del
and slash
"ESM only" packages
Yeah, that makes things so much leaner than in the previous iteration you showed 🙌🏻 . question Is there any reason we wouldn't want to configure Babel for all 4 projects? Worried that we one day add one of these packages to the projects and we miss that Babel is not set up for them. suggestion: Is it worth having a |
Enables Babel transform for ESM-only packages (to CommonJS) until Jest supports ESM https://jestjs.io/docs/ecmascript-modules Babel ignores `node_modules` by default
be1e33d
to
9495171
Compare
Thanks @romaricpascal
Don't mind at all. Assumed we'd only add it (temporarily) where needed—but pushed again 👍
As the code reviewer, would you like that? 😊 Might not be necessary now it's only defined once at the top? |
Do we want to upgrade our pinned packages with "ESM only" updates?
There's a two-step process (unfortunately) which needs:
We need 2) until Node.js unflags
--experimental-vm-modules
for Jest ECMAScript Modules supportUpdate: Various related links