Update stylelint config defaults #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default stylelint will attempt to check for “CSS in JS” but this is causing issues to be flagged in editors when destructuring objects
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2916
5 tasks
|
This PR was related to #2243 |
domoscargin
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more quick update to fully close #2710
This PR does three things:
postcss-scsscustom syntax'**/*.{cjs,js,mjs}'files and built CSSWhy the changes?
When we upgraded to Stylelint v14 (see migration guide) we accidentally opted in to "CSS-in-JS" validation. We didn't notice this in our GitHub workflow or via
gulp scss:lintbecause we didn't lint anything but*.scssfiles:stylelint 'app/**/*.scss' 'src/**/*.scss'BUT for code editors using a Stylelint plugin they see errors in all files that Stylelint supports, including JavaScript: