Use single compileStyles Sass helper function
#2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
|
Also comes under "does too much" so is also linked with #2243 |
colinrotherham
force-pushed
the
postcss-config
branch
from
5495a55 to
cf0e7ed
Compare
colinrotherham
force-pushed
the
postcss-config-task
branch
from
8f9f84f to
d52cd51
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
colinrotherham
force-pushed
the
postcss-config-task
branch
from
d52cd51 to
6dab3f6
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
colinrotherham
force-pushed
the
postcss-config
branch
from
cf0e7ed to
cb146a2
Compare
colinrotherham
force-pushed
the
postcss-config-task
branch
from
6dab3f6 to
34dab77
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
colinrotherham
force-pushed
the
postcss-config
branch
2 times, most recently
from
db0c833 to
de8ec57
Compare
colinrotherham
force-pushed
the
postcss-config-task
branch
from
34dab77 to
6eca088
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
colinrotherham
force-pushed
the
postcss-config
branch
from
de8ec57 to
c2b50c5
Compare
colinrotherham
force-pushed
the
postcss-config-task
branch
from
6eca088 to
4b1a849
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
36degrees
approved these changes
Oct 18, 2022
colinrotherham
force-pushed
the
postcss-config-task
branch
from
4b1a849 to
298927f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
colinrotherham
force-pushed
the
postcss-config-task
branch
from
298927f to
1a3a45e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
colinrotherham
force-pushed
the
postcss-config-task
branch
from
1a3a45e to
67b62e9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #2881
Knowing we now have a postcss.config.js file that handles:
app-**.min.cssWe can now combine the various task functions
compileOldIE(),compileLegacy(),compileLegacyIE(),compileFullPageStyles()into a singlecompileStyles()