Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stray let in I18n preventing uglify (into main) #2870

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Sep 21, 2022

This is a copy of #2868 with main as the base

I've also included a required bug fix:

Fix for a YAML to JSON “write after end” race condition
The gulp copy-files stream can only write one JSON file fixtures.json or macro-options.json as shown

Original description

This PR fixes a tiny letvar which caused a fairly obscure GulpUglifyError

[18:55:27] GulpUglifyError: unable to minify JavaScript
Caused by: SyntaxError: Unexpected token: name «placeholderValue», expected: punc «;»
File: /Users/colin/Sites/GDS/govuk-frontend/src/govuk/all.mjs
Line: 524
Col: 10

To catch this next time I've added the other npm build:* scripts to the GitHub workflow:

- name: Build
  run: |
    npm run build:assets
    npm run build:package
    npm run build:dist

@colinrotherham colinrotherham requested a review from a team as a code owner September 21, 2022 10:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2870 September 21, 2022 10:30 Inactive
@colinrotherham colinrotherham changed the title Fix stray let in I18n preventing uglify (again) Fix stray let in I18n preventing uglify (again) Sep 21, 2022
@colinrotherham colinrotherham changed the title Fix stray let in I18n preventing uglify (again) Fix stray let in I18n preventing uglify (into main) Sep 21, 2022
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2870 September 21, 2022 10:54 Inactive
}))
.pipe(yamlFiles.restore)
.pipe(gulp.dest(taskArguments.destination + '/govuk/'))
return merge(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file have been brought over from #2862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants