Add new example page of all translated components to review app #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2809
vanitabarrett
force-pushed
the
vbs-add-i18n-component-example-page
branch
from
4d5d5be to
ba6cbc8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2809
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2809
36degrees
reviewed
Aug 26, 2022
vanitabarrett
force-pushed
the
vbs-add-i18n-component-example-page
branch
from
ba6cbc8 to
bd249ff
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2809
Have translated all strings that are currently possible to translate (should be everything apart from strings in hardcoded JS)
vanitabarrett
force-pushed
the
vbs-add-i18n-component-example-page
branch
from
bd249ff to
345e8cd
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this relies on @querkmachine 's change to allow translation of the character count fallback message. Please only review the second commit.
Closes #2692
What
Adds a new example page containing all GOV.UK Frontend components, translated into Welsh. This includes translation of text in Nunjucks/HTML, not strings in component JavaScript code as we haven't begun our implementation to allow that yet.
This should also include translation of any HTML attributes, e.g: aria labels.
Note: the card was originally written with the end goal of having a full page realistic example of translated components, but it didn't feel possible to have a realistic page with all components in, so I've instead opted for just a "list" of all components on a page instead.
Why
➡️ Preview link: https://govuk-frontend-pr-2809.herokuapp.com/examples/translated