Refactor asset-version build task to remove Gulp dependency #2763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Gulp dependency from the asset-version build task. Resolves #2715.
Specifically, this PR:
update-assets-version
Gulp task to be an exported JavaScript function, renamed asupdateDistAssetsVersion
.asset-version.js
to thetasks
directory.destination
variable fromtask-arguments.js
to determine where compiled files go, as per this comment. This task only ever seems to compile todist
, so this has been hardcoded.vinyl-paths
package, as this is no longer used anywhere.gulpfile.js
to integrate the renamed task.Related changes:
task-arguments.js
to thetasks
directory.task-arguments.js
.These changes appear to produce the expected compiled files, filenames, and passes our automated tests.
Note: The
updateDistAssetsVersion
function is required to accept and return a callback function so that it can be integrated with the existing Gulp tasks. This could be removed once we've gotten rid of Gulp entirely.