Error message and summary list translated examples #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
error-message-summary-list-translate-examples
branch
from
619552f to
0050853
Compare
vanitabarrett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2690
What
Add visual examples to the review app for translating the error message and summary list actions.
Add tests for translating the error message and summary list actions.
Why
Both components have hardcoded visually hidden text. To translate these you can use a bit of a workaround - remove the visually hidden text using
visuallyHiddenText: falseand setting your ownhtmlwhich includes the visually hidden text.We should have examples and tests for this, so we don't change the logic without considering this use case.