Skip to content

Commit

Permalink
Use review app start script for Heroku
Browse files Browse the repository at this point in the history
  • Loading branch information
colinrotherham committed Mar 29, 2023
1 parent fc65463 commit dbf4586
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion Procfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
web: npm run heroku
web: npm start --workspace app
5 changes: 0 additions & 5 deletions docs/contributing/tasks.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ npm scripts are defined in `package.json`. These trigger a number of Gulp tasks.

- start up Express, restarting when `.mjs`, `.json` or `.yaml` files change

**`npm run heroku` runs on Heroku build/PR and it will:**

- run `npm run build:app`
- start up Express

**`npm run build:app` will do the following:**

- clean the `./app/dist` folder
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"scripts": {
"postinstall": "npm ls --depth=0",
"start": "npm run dev --workspace app",
"heroku": "npm run build:app && npm start --workspace app",
"build-release": "./bin/build-release.sh",
"publish-release": "./bin/publish-release.sh",
"pre-release": "./bin/pre-release.sh",
Expand Down

0 comments on commit dbf4586

Please sign in to comment.