Skip to content

Commit

Permalink
Explicitly set outline-offset to remove 1px transparent border in chr…
Browse files Browse the repository at this point in the history
…ome > 84

Chrome 83 appears to have changed the default outline-offset to 1px, which then adds a transparent border to the skip link. This explicitly sets it to 0 to hide that border.

Fix error due to linting rule

removed 'px' for 0 value
  • Loading branch information
rorywilsonros authored and Vanita Barrett committed Jul 23, 2020
1 parent cea9996 commit d2044ab
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ We’ve made fixes to GOV.UK Frontend in the following pull requests:
- [#1861: Fix the display of checkboxes when border-box box sizing is applied globally](https://github.com/alphagov/govuk-frontend/pull/1861)
- [#1862: Fix display of warning text icon when border-box box sizing is applied globally #1862](https://github.com/alphagov/govuk-frontend/pull/1862)
- [#1848: Preserve the state of the character count when navigating 'back' in the browser](https://github.com/alphagov/govuk-frontend/pull/1848)
- [#1879: Explicitly set outline-offset to remove 1px transparent border in chrome v84](https://github.com/alphagov/govuk-frontend/pull/1879)

## 3.7.0 (Feature release)

Expand Down
1 change: 1 addition & 0 deletions src/govuk/components/skip-link/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

&:focus {
outline: $govuk-focus-width solid $govuk-focus-colour;
outline-offset: 0;
background-color: $govuk-focus-colour;

// Undo unwanted changes when global styles are enabled
Expand Down

0 comments on commit d2044ab

Please sign in to comment.