Merge pull request #743 from alphagov/use-relative-imports-in-components

Use relative imports in components

src/components/all.test.js

@@ -0,0 +1,27 @@
+/* eslint-env jest */
+
+const { allComponents } = require('../../lib/file-helper')
+
+const configPaths = require('../../config/paths.json')
+
+// We can't use the render function from jest-helpers, because we need control
+// over the nunjucks environment.
+const nunjucks = require('nunjucks')
+
+describe('When nunjucks is configured with a different base path', () => {
+  beforeAll(() => {
+    // Create a new Nunjucks environment that uses the src directory as its
+    // base path, rather than the components folder itself
+    nunjucks.configure(configPaths.src)
+  })
+
+  allComponents.forEach((component) => {
+    describe(`the ${component} component`, () => {
+      it('can be rendered without erroring', () => {
+        expect(() => {
+          nunjucks.render(`components/${component}/template.njk`, {})
+        }).not.toThrow()
+      })
+    })
+  })
+})

src/components/checkboxes/template.njk

@@ -1,7 +1,7 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "fieldset/macro.njk" import govukFieldset %}
-{% from "hint/macro.njk" import govukHint %}
-{% from "label/macro.njk" import govukLabel %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../fieldset/macro.njk" import govukFieldset %}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../label/macro.njk" import govukLabel %}
 
 {#- If an id 'prefix' is not passed, fall back to using the name attribute
    instead. We need this for error messages and hints as well -#}

src/components/date-input/template.njk

@@ -1,7 +1,7 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "fieldset/macro.njk" import govukFieldset %}
-{% from "hint/macro.njk" import govukHint %}
-{% from "input/macro.njk" import govukInput %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../fieldset/macro.njk" import govukFieldset %}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../input/macro.njk" import govukInput %}
 
 {#- a record of other elements that we need to associate with the input using
    aria-describedby – for example hints or error messages -#}

src/components/file-upload/template.njk

@@ -1,6 +1,6 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "hint/macro.njk" import govukHint %}
-{% from "label/macro.njk" import govukLabel %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../label/macro.njk" import govukLabel %}
 
 {#- a record of other elements that we need to associate with the input using
    aria-describedby – for example hints or error messages -#}

src/components/input/template.njk

@@ -1,6 +1,6 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "hint/macro.njk" import govukHint %}
-{% from "label/macro.njk" import govukLabel %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../label/macro.njk" import govukLabel %}
 
 {#- a record of other elements that we need to associate with the input using
    aria-describedby – for example hints or error messages -#}

src/components/phase-banner/template.njk

@@ -1,4 +1,4 @@
-{% from "tag/macro.njk" import govukTag -%}
+{% from "../tag/macro.njk" import govukTag -%}
 
 <div class="govuk-phase-banner
   {%- if params.classes %} {{ params.classes }}{% endif %}"{% for attribute, value in params.attributes %} {{ attribute }}="{{ value }}"{% endfor %}>

src/components/radios/template.njk

@@ -1,7 +1,7 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "fieldset/macro.njk" import govukFieldset %}
-{% from "hint/macro.njk" import govukHint %}
-{% from "label/macro.njk" import govukLabel %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../fieldset/macro.njk" import govukFieldset %}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../label/macro.njk" import govukLabel %}
 
 {#- If an id 'prefix' is not passed, fall back to using the name attribute
    instead. We need this for error messages and hints as well -#}

src/components/select/template.njk

@@ -1,6 +1,6 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "hint/macro.njk" import govukHint %}
-{% from "label/macro.njk" import govukLabel %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../label/macro.njk" import govukLabel %}
 
 {#- a record of other elements that we need to associate with the input using
    aria-describedby – for example hints or error messages -#}

src/components/textarea/template.njk

@@ -1,6 +1,6 @@
-{% from "error-message/macro.njk" import govukErrorMessage -%}
-{% from "hint/macro.njk" import govukHint %}
-{% from "label/macro.njk" import govukLabel %}
+{% from "../error-message/macro.njk" import govukErrorMessage -%}
+{% from "../hint/macro.njk" import govukHint %}
+{% from "../label/macro.njk" import govukLabel %}
 
 {#- a record of other elements that we need to associate with the input using
    aria-describedby – for example hints or error messages -#}

src/components/warning-text/template.njk

@@ -1,5 +1,3 @@
-{% from "warning-text/macro.njk" import govukWarningText -%}
-
 <div class="govuk-warning-text {{- ' ' + params.classes if params.classes}}"
   {%- for attribute, value in params.attributes %} {{attribute}}="{{value}}"{% endfor -%}
   >