Use simpler default example for text inputs #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default example for the text input component from an input asking for an email address to an example asking for someone’s full name. As raised in the backlog [1], we are not currently using the correct `type=“email”`. We could fix this, but as users are likely to take this ‘default’ example and modify it to ask different questions, it makes sense to make it as generic as possible, avoiding using a type specific to a particular type of input. Therefore changing to a more ‘generic’ question, such as full name, which does not require specific input types, makes more sense. [1]: alphagov/govuk-design-system-backlog#51 (comment)
|
You can preview this change here: Built with commit 7c74fdc https://deploy-preview-511--govuk-design-system-preview.netlify.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default example for the text input component from an input asking for an email address to an example asking for someone’s full name.
As raised in the backlog, we are not currently using the correct
type=“email”. We could fix this, but as users are likely to take this ‘default’ example and modify it to ask different questions, it makes sense to make it as generic as possible, avoiding using a type specific to a particular type of input.Therefore changing to a more ‘generic’ question, such as full name, which does not require specific input types, makes more sense.