Use createAll to initialise components in the Design System site
#4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Adds entry in .browserslistrc for our JavaScript supported browsers - Update Babel's configuration to use that list when compiling JavaScript - Configure Rollup to run Babel when bundling JavaScript
romaricpascal
force-pushed
the
use-create-all
branch
from
1f2fdbe to
370c1f0
Compare
Aligns the naming with the `data-module` attribute, which is more precise than just 'example'
romaricpascal
force-pushed
the
use-create-all
branch
from
370c1f0 to
5ee912a
Compare
romaricpascal
commented
Aug 19, 2024
Comment on lines
+37
to
+38
| this.$module.prepend(this.$status) | ||
| this.$module.prepend(this.$button) |
There was a problem hiding this comment.
note $module is no longer the <pre> element containing the code, but the <div> wrapping it, which simplifies the insertion of the button and hidden status for assistive technology.
patrickpatrickpatrick
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As using
createAllrequires component to hold a staticmoduleNameproperty, this PR updates the build process to add transpilation of the JavaScript with Babel (rather than relying on code being authored to match JavaScript features, linted by es-x).It then uses createAll to instantiate components that were previously looked up using
document.querySelector[All]inapplication.js.Components not updated
OptionsTableworks based on the hash, rather than specific elements on the page. It could actually be refactored as a function rather than a class.Navigationdoesn't really have a 'root' element as it looks things up in the document. It could be broken down into two components with root elements, one for the menu itself and the other for the subnav collapsing, but that's a different refactoring.Fixes #3812