Ask users to make pattern title call to action #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EoinShaughnessy
added
🕔 hours
check answers
|
✔️ You can preview this change here: 🔨 Explore the source changes: 3d93043 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61d5b58a0d28a000076de7e9 😎 Browse the preview: https://deploy-preview-2011--govuk-design-system-preview.netlify.app |
EoinShaughnessy
commented
Jan 4, 2022
EoinShaughnessy
force-pushed
the
page-title-check-answers
branch
from
1ba5d8c to
3babe63
Compare
|
@calvin-lau-sig7 Have added in your suggestion. Can I get a review? :) |
EoinShaughnessy
force-pushed
the
page-title-check-answers
branch
from
c93d270 to
3d93043
Compare
calvin-lau-sig7
approved these changes
Jan 5, 2022
|
@calvin-lau-sig7 Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #706.
This PR updates the guidance for our check answers pattern.
We're changing a bullet so that it explicitly recommends making the page title a call to action. This is because some users didn't know they had to do something.