Add OrganisationLogo model #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
reviewed
Mar 3, 2025
deborahchua
force-pushed
the
update-logo-model
branch
from
a6657de to
1692348
Compare
We require the organisation `base_path` in the `organisation_logo` publishing component. Not all logos require the base path, so it makes sense to have a separate model that extends the Logo model. See https://components.publishing.service.gov.uk/component-guide/organisation_logo#how-to-call-this-component
deborahchua
force-pushed
the
update-logo-model
branch
from
1692348 to
cc92be0
Compare
deborahchua
changed the title
deborahchua
added a commit
that referenced
this pull request
Mar 6, 2025
This was originally added #4673 to accomodate including the `base_path` as the `url` for the `organisation_logo` publishing component which is not always required for a logo. However, we can transform the data required for the component in the view by passing a hash similar to https://github.com/alphagov/government-frontend/blob/baef09ffcce08cc557a7c01e952824ee803d70f9/app/presenters/content_item/organisation_branding.rb#L8-L13 , so having this additional model is not necessary, and we can directly access the `base_path` from the `content_item`. The view will be updated in a separate commit.
deborahchua
added a commit
that referenced
this pull request
Mar 6, 2025
This was originally added #4673 to accomodate including the `base_path` as the `url` for the `organisation_logo` publishing component which is not always required for a logo. However, we can transform the data required for the component in the view by passing a hash similar to https://github.com/alphagov/government-frontend/blob/baef09ffcce08cc557a7c01e952824ee803d70f9/app/presenters/content_item/organisation_branding.rb#L8-L13 , so having this additional model is not necessary, and we can directly access the `base_path` from the `content_item`. The view will be updated in a separate commit.
deborahchua
added a commit
that referenced
this pull request
Mar 6, 2025
This was originally added #4673 to accomodate including the `base_path` as the `url` for the `organisation_logo` publishing component which is not always required for a logo. However, we can transform the data required for the component in the view by passing a hash similar to https://github.com/alphagov/government-frontend/blob/baef09ffcce08cc557a7c01e952824ee803d70f9/app/presenters/content_item/organisation_branding.rb#L8-L13 , so having this additional model is not necessary, and we can directly access the `base_path` from the `content_item`. The view will be updated in a separate commit.
deborahchua
added a commit
that referenced
this pull request
Mar 6, 2025
This was originally added #4673 to accomodate including the `base_path` as the `url` for the `organisation_logo` publishing component which is not always required for a logo. However, we can transform the data required for the component in the view by passing a hash similar to https://github.com/alphagov/government-frontend/blob/baef09ffcce08cc557a7c01e952824ee803d70f9/app/presenters/content_item/organisation_branding.rb#L8-L13 , so having this additional model is not necessary, and we can directly access the `base_path` from the `content_item`. The view will be updated in a separate commit.
deborahchua
added a commit
that referenced
this pull request
Mar 6, 2025
This was originally added #4673 to accomodate including the `base_path` as the `url` for the `organisation_logo` publishing component which is not always required for a logo. However, we can transform the data required for the component in the view by passing a hash similar to https://github.com/alphagov/government-frontend/blob/baef09ffcce08cc557a7c01e952824ee803d70f9/app/presenters/content_item/organisation_branding.rb#L8-L13 , so having this additional model is not necessary, and we can directly access the `base_path` from the `content_item`. The view will be updated in a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a new OrganisationLogo model which extends Logo model, which takes the organisation's
base_pathas one of its arguments.Why
We require the organisation
base_pathin theorganisation_logopublishing component. Not all logos require the base path, so it makes sense to have a separate model that extends the Logo model.See https://components.publishing.service.gov.uk/component-guide/organisation_logo#how-to-call-this-component
This is part of the app consolidation work and it is in preparation of using this component in various document types.
Trello card