Add check for available translations #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
force-pushed
the
add-check-for-translations
branch
from
0c41b94 to
d59626a
Compare
The available translations method looks through the `available_translations` and replaces the English translation with `""`. That means that if there's only an English translation, then the `available_translations` will return `[""]`. `any?` was being used in the view to determine whether or not to display the translations partial, however, `any?` returns true for `[""]`. ``` frontend(dev)> a = [""] => [""] frontend(dev)> a.any? => true frontend(dev)> a.length > 1 => false ``` So rather than not rendering anything when there is only an English translation, an empty `div` was being rendered: `<div class="govuk-grid-column-one-third"></div>` Instead of `any?` the original logic from [government-frontend] is being reinstated. This logic has been made into a method in the model so that it can be easily tested. [government-frontend]: https://github.com/alphagov/government-frontend/blob/85f4681feed9ed3b57bb7f2ea0dce10bf6e0338a/app/views/shared/_translations.html.erb#L1
leenagupte
force-pushed
the
add-check-for-translations
branch
from
d59626a to
ed46929
Compare
deborahchua
approved these changes
Feb 26, 2025
KludgeKML
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reinstate the original logic from government-frontend to check for the presence of translations.
Why
The available translations method looks through the
available_translationsand replaces the English translation with"".That means that if there's only an English translation, then the
available_translationswill return[""].any?was being used in the view to determine whether or not to display the translations partial, however,any?returns true for[""].So rather than not rendering anything when there is only an English translation, an empty
divwas being rendered:<div class="govuk-grid-column-one-third"></div>Instead of
any?the original logic from government-frontend is being reinstated.This logic has been made into a method in the model so that it can be easily tested.
See: #4600 (review)