Add inverse flag to govuk_styled_links_list helper #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leenagupte
commented
Feb 25, 2025
leenagupte
commented
KludgeKML
reviewed
Feb 25, 2025
app/helpers/link_helper.rb
Outdated
| @@ -17,6 +17,6 @@ def govuk_styled_link(text, path: nil, inverse: false) | |||
| end | |||
|
|
|||
| def govuk_styled_links_list(links) | |||
There was a problem hiding this comment.
Ah, I think I was assuming that this would be an all or nothing thing - that you'd have:
def govuk_styled_links_list(links, inverse: false)
...is there a market for having some links in a single list inverse, and some not?
There was a problem hiding this comment.
Hmm, that's a good shout. Will update.
leenagupte
force-pushed
the
add-inverse-to-helper
branch
from
d4e8932 to
877407f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.