Add contents list with body component #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies the component as-is from government-frontend. The test has been updated to use RSpec. Audit trail: css: https://github.com/alphagov/government-frontend/blob/a7e99cf556dbc5d8b8fab5a317157136cadeb8a0/app/assets/stylesheets/components/_contents-list-with-body.scss docs: https://github.com/alphagov/government-frontend/blob/a7e99cf556dbc5d8b8fab5a317157136cadeb8a0/app/views/components/docs/contents_list_with_body.yml test: https://github.com/alphagov/government-frontend/blob/a7e99cf556dbc5d8b8fab5a317157136cadeb8a0/test/components/contents_list_with_body_test.rb view: https://github.com/alphagov/government-frontend/blob/a7e99cf556dbc5d8b8fab5a317157136cadeb8a0/app/views/components/_contents_list_with_body.html.erb dartsass.rb:https://github.com/alphagov/government-frontend/blob/a7e99cf556dbc5d8b8fab5a317157136cadeb8a0/config/initializers/dartsass.rb
|
This component also uses some sticky element javascript which shows a sticky element container with the contents link to the bottom of the page when you scroll down the page (and disappears when you are back at the top) - 1192e28 |
That's a good spot. Thanks! |
The copies the sticky-element-container files as-is from government-frontend The sticky element javascript shows a sticky element container with the contents link to the bottom of the page when you scroll down the page (and disappears when you are back at the top). Audit trail: application.scss: https://github.com/alphagov/government-frontend/blob/7616a5ecc5991a69411b19b84935e952f203967a/app/assets/stylesheets/application.scss#L20 _sticky-element-container.scss: https://github.com/alphagov/government-frontend/blob/7616a5ecc5991a69411b19b84935e952f203967a/app/assets/stylesheets/helpers/_sticky-element-container.scss sticky-element-container.js: https://github.com/alphagov/government-frontend/blob/7616a5ecc5991a69411b19b84935e952f203967a/app/assets/javascripts/modules/sticky-element-container.js sticky-element-container.spec.js: https://github.com/alphagov/government-frontend/blob/7616a5ecc5991a69411b19b84935e952f203967a/spec/javascripts/modules/sticky-element-container.spec.js
This is for consistency with what other files are doing and to pass the minimum jasmine coverage required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Copies contents-list-with-body component from government-frontend
Why
This component is used by both specialist documents and corporate information pages which are in the middle of being consolidated
Screenshots?