Set facet type to link in specialist document model

alphagov · Feb 25, 2025 · afc41a3 · afc41a3
1 parent b36017e
commit afc41a3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/app/models/specialist_document.rb b/app/models/specialist_document.rb
@@ -20,8 +20,6 @@ def facet_values
       f = {
         key: selected_facet["key"],
         name: selected_facet["name"],
-        type: selected_facet["type"],
-        filterable: selected_facet["filterable"],
       }
 
       metadata_facet_value = metadata[selected_facet["key"]]
@@ -35,6 +33,15 @@ def facet_values
                   else
                     metadata_facet_value
                   end
+
+      f[:type] = if selected_facet["type"] == "text" &&
+          f[:value].is_a?(Array) &&
+          selected_facet["filterable"] == true
+                   "link"
+                 else
+                   selected_facet["type"]
+                 end
+
       f
     end
   end

diff --git a/spec/models/specialist_document_spec.rb b/spec/models/specialist_document_spec.rb
@@ -111,8 +111,7 @@
           {
             key: "aircraft_category",
             name: "Aircraft category",
-            type: "text",
-            filterable: true,
+            type: "link",
             value: [{
               label: "Sport aviation and balloons",
               value: "sport-aviation-and-balloons",
@@ -121,8 +120,7 @@
           {
             key: "report_type",
             name: "Report type",
-            type: "text",
-            filterable: true,
+            type: "link",
             value: [{
               label: "Bulletin - Correspondence investigation",
               value: "correspondence-investigation",
@@ -132,28 +130,24 @@
             key: "date_of_occurrence",
             name: "Date of occurrence",
             type: "date",
-            filterable: true,
             value: "2015-08-08",
           },
           {
             key: "aircraft_type",
             name: "Aircraft type",
             type: "text",
-            filterable: false,
             value: "Rotorsport UK Calidus",
           },
           {
             key: "location",
             name: "Location",
             type: "text",
-            filterable: false,
             value: "Damyns Hall Aerodrome, Essex",
           },
           {
             key: "registration",
             name: "Registration",
             type: "text",
-            filterable: false,
             value: "G-PCPC",
           },
         ]
@@ -170,8 +164,7 @@
           {
             key: "alert_type",
             name: "Alert type",
-            type: "text",
-            filterable: true,
+            type: "link",
             value: [{
               label: "Medical device alert",
               value: "devices",
@@ -180,8 +173,7 @@
           {
             key: "medical_specialism",
             name: "Medical specialty",
-            type: "text",
-            filterable: true,
+            type: "link",
             value: [
               {
                 label: "Critical care",
@@ -209,7 +201,6 @@
             key: "issued_date",
             name: "Issued",
             type: "date",
-            filterable: true,
             value: "2015-07-06",
           },
         ]