Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Spike: Rust api #2

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Spike: Rust api #2

wants to merge 30 commits into from

Conversation

0atman
Copy link

@0atman 0atman commented Feb 7, 2022 •
edited
Loading

  • user "auth"
  • OpenAPI UI
  • GH actions for build + lint

API design

  • post "/publish"
  • def form_exists_for_user?(user, key)
  • get "/published"
  • get "/published/:id"
  • def authenticated_user
  • def forms_for_user(user)
  • def seed_data_for_user(user)
  • get "/seed/:user" (optional, designer expects forms to exist)

@0atman 0atman self-assigned this Feb 7, 2022
@0atman 0atman changed the title Initial rust project Spike: Rust api Feb 8, 2022
0atman
0atman commented Feb 9, 2022
View reviewed changes
@0atman
Copy link
Author

0atman commented Feb 14, 2022

openapi UI working (actually it was working last week)

Screenshot from 2022-02-14 17-53-10

@0atman
Copy link
Author

0atman commented Feb 15, 2022

Screenshot from 2022-02-15 16-57-46

0atman
0atman commented Feb 22, 2022
View reviewed changes
0atman
0atman commented Feb 22, 2022
View reviewed changes
rust-api/src/api.rs Outdated
id,
"INSERT INTO forms
VALUES ($1, $2, $3, $4, $5)
RETURNING *;",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to add RETURNING if you want postgres to give you the table back, otherwise you just get "1 row(s) updated" etc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took me longer than I care to admit to realise this...

0atman
0atman commented Feb 22, 2022
View reviewed changes
0atman and others added 5 commits February 22, 2022 16:54
@0atman
Contract the form response
b19d0dd
@0atman
Merge branch 'rust-prototype' of github.com:alphagov/forms-api-protot…
01f59e2 
…ype into rust-prototype
@0atman
Publish new forms for user
3da8cac
@0atman @alice-carr
Refactored forms into module
607c276 
get /published for user working

Co-authored-by: alice-carr <alice-carr@users.noreply.github.com>
@0atman @james-sheppard-gov-uk
API version pulled from cargo.toml
d24d1c4 
Co-authored-by: James Sheppard <james-sheppard-gov-uk@users.noreply.github.com>
0atman
0atman commented Feb 28, 2022
View reviewed changes
rust-api/src/main.rs
let api_service = OpenApiService::new(
api::Api,
"Forms API Rust Prototype",
env!("CARGO_PKG_VERSION"))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-sheppard-gov-uk being a genius suggsted we get the semver from the cargo.toml 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@0atman 0atman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0atman @danielburnley