Remove margin top from filter summary component #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to maintain spacing, I've added a 'margin-bottom: 10px' to the filter panel component. This should not result in any visual differences as the filter summary always renders beneath the filter panel.
AshGDS
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
This PR removes
margin-top: 10pxfrom the filter summary component and addsmargin-bottom: 10pxon the filter panel component. This should not result in any visual differences as the filter summary always renders below the filter panel and the original 10px of spacing is maintained - the only difference is in how it is applied.Why
Trello card
Visual changes
Hopefully none but these are some pages that can be checked:
Local / live (only filter panel rendered)
Local / live (filter panel rendered with filter summary)