Feature/rename package #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toloudis
requested review from
interim17 and
ShrimpCryptid
and removed request for
a team
Comment on lines
+43
to
+44
| const volume = await loader.createVolume(loadSpec, (v: Volume, channelIndex: number) => { | ||
| const currentVol = v; |
There was a problem hiding this comment.
Consider breaking the callback out into a const for better readability?
docs/index.html
Outdated
There was a problem hiding this comment.
Is there anything in here we should pay special attention to?
There was a problem hiding this comment.
not really.. mainly just needed to pick up the package name and I decided to do it by running a docs rebuild. But the docs are terribly out of date and can basically be ignored
Co-authored-by: Peyton Lee <peyton.lee@alleninstitute.org>
Co-authored-by: Peyton Lee <peyton.lee@alleninstitute.org>
Co-authored-by: Peyton Lee <peyton.lee@alleninstitute.org>
ShrimpCryptid
approved these changes
Nov 25, 2024
interim17
approved these changes
Nov 26, 2024
7 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly we need to update the npm package as part of renaming Vol-E.
@aics/vole-coreSome of the changes in here are due to auto-formatting, sorry about that.