Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement pod selector and use it in predication of pod reconciliations #412

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mars1024
Copy link
Collaborator

@mars1024 mars1024 commented Mar 1, 2024

Pull Request Description

Describe what this PR does / why we need it

Support configurable pod label selector for selecting specified pods for IPAM.

Does this pull request fix one issue?

#411

Describe how you did it

NONE

Describe how to verify it

NONE

Special notes for reviews

Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
@mars1024 mars1024 requested review from hhyasdf and sjtufl March 1, 2024 07:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 38.24%. Comparing base (33b4865) to head (30cd2f7).

Files Patch % Lines
pkg/controllers/networking/pod_controller.go 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   41.31%   38.24%   -3.07%     
==========================================
  Files          42       48       +6     
  Lines        2757     3004     +247     
==========================================
+ Hits         1139     1149      +10     
- Misses       1501     1736     +235     
- Partials      117      119       +2     
Flag Coverage Δ
unittests 38.24% <76.47%> (-3.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sjtufl sjtufl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sjtufl sjtufl merged commit f673ea3 into alibaba:main Apr 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants