Bump up minimum Python version to 3.10 #313
Conversation
| @@ -1,3 +1,3 @@ | |||
| sphinx==4.0.1 | |||
| sphinx==4.2.0 | |||
There was a problem hiding this comment.
sphinx 4.2.0 is the first version that seems to work with Python 3.10, see discussion here
There was a problem hiding this comment.
@algochoi Thanks for the effort to bump the minimum Python version.
Take my approval with a grain of salt due to my lack of py-algorand-sdk experience. Here's what I checked:
- Visually sanity checked build steps to confirm tests executing as intended.
- Opened a draft PR to confirm pyteal works as a consumer: Test py-algorand-sdk Python version bump pyteal#275.
- Looked for missed Python version references via
git grep "3\.".
There was a problem hiding this comment.
@algochoi Sorry for the late change, but I dismissed my approval due to algorand/pyteal#276.
Let's wait until algorand/pyteal#276 is merged to confirm our understanding.
It feels like the repo ought to define a .readthedocs.yaml. I don't (yet) have a readthedocs login, so I don't know what web configurations exist. And it seems preferable to rely on a local, versioned config.
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
There was a problem hiding this comment.
@algochoi Thanks for the effort here to bring py-algorand-sdk up to Python 3.10! ☕
This reverts commit 006b3a0.
This PR deletes the outdated travis configurations, and updates the python_requires version from 3.5 to 3.10. It also updates the Circle/Docker image Python versions to
3.10.xas well.Currently, the minimum Python version supported by pynacl, one of our dependencies, is 3.6. It makes sense for our SDK to move to a higher version as well. Since PyTeal depends on this repo, we should also bump up the minimum Python version there too.
Closes #300