Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdeploy: add KmdJSONOverride #6269

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Mar 7, 2025

Summary

Sometimes e2e tests fail with handle does not exist error. It ended up to be a wallet handle expiration issue: tests get a handle at the very beginning and keep using it till the end. Handle expiration is 60 seconds and a test can take longer. KMD starts a background thread that removes handles after expiration and there is no way to renew if it was removed.

To solve this I added a new KmdJSONOverride field to network templates (similar to ConfigJSONOverride) to set SessionLifetimeSecs to 5 minutes. At the moment modified only TwoNodes50Each.json and TwoNodes50EachFuture.json templates as the most common ones and ones with such failures.

Test Plan

Run some existing e2e tests locally.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Project coverage is 51.75%. Comparing base (269945c) to head (a27b0ef).

Files with missing lines Patch % Lines
netdeploy/networkTemplate.go 25.00% 21 Missing ⚠️
daemon/kmd/config/config.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6269      +/-   ##
==========================================
- Coverage   51.78%   51.75%   -0.03%     
==========================================
  Files         644      644              
  Lines       86697    86729      +32     
==========================================
- Hits        44894    44888       -6     
- Misses      38933    38974      +41     
+ Partials     2870     2867       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants