Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes e2e tests fail with
handle does not exist
error. It ended up to be a wallet handle expiration issue: tests get a handle at the very beginning and keep using it till the end. Handle expiration is 60 seconds and a test can take longer. KMD starts a background thread that removes handles after expiration and there is no way to renew if it was removed.To solve this I added a new
KmdJSONOverride
field to network templates (similar toConfigJSONOverride
) to setSessionLifetimeSecs
to 5 minutes. At the moment modified onlyTwoNodes50Each.json
andTwoNodes50EachFuture.json
templates as the most common ones and ones with such failures.Test Plan
Run some existing e2e tests locally.