-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: fix http RoundTripper #6267
Merged
algorandskiy
merged 1 commit into
algorand:master
from
algorandskiy:pavel/p2p-fast-catchup-2
Mar 7, 2025
Merged
p2p: fix http RoundTripper #6267
algorandskiy
merged 1 commit into
algorand:master
from
algorandskiy:pavel/p2p-fast-catchup-2
Mar 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6267 +/- ##
==========================================
- Coverage 51.80% 51.78% -0.03%
==========================================
Files 644 644
Lines 86655 86697 +42
==========================================
+ Hits 44893 44895 +2
- Misses 38897 38936 +39
- Partials 2865 2866 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cce
reviewed
Mar 7, 2025
cce
approved these changes
Mar 7, 2025
algogm
previously approved these changes
Mar 7, 2025
gmalouf
approved these changes
Mar 7, 2025
Submitted a PR into upstream libp2p/go-libp2p#3225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Catchpoint downloading uses
http.Client
withhttp.Request
's context with timeout set toMaxCatchpointDownloadDuration=43200
seconds. If p2p nodes do not respond, this context never expires so thathttp.Client
waits forMaxCatchpointDownloadDuration
.Fixed by copying
libp2phttp.streamRoundTripper.RoundTrip
but using sensible context with timeout onNewStream
call.Closes #6265
Test Plan
Tested manually with
catchpointdump
andgoal node catchup
:catchpointdump
successfully exits when run agains a node that does not respondalgod
was fully caught up in under 2h