Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchpointdump: support p2p nodes #6266

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

  1. Allow catchpointdump utility to download catchpoint files from p2p archival nodes
  2. Fixed a typo in checkLedgerDownload

Test Plan

Tested manually

@algorandskiy algorandskiy added New Feature p2p Work related to the p2p project labels Mar 4, 2025
@algorandskiy algorandskiy requested review from cce and gmalouf March 4, 2025 22:28
@algorandskiy algorandskiy self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 51.80%. Comparing base (f468e57) to head (45e08fb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/catchpointdump/net.go 0.00% 15 Missing ⚠️
catchup/catchpointService.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6266      +/-   ##
==========================================
+ Coverage   49.77%   51.80%   +2.03%     
==========================================
  Files         644      644              
  Lines       86644    86655      +11     
==========================================
+ Hits        43123    44893    +1770     
+ Misses      40608    38898    -1710     
+ Partials     2913     2864      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@algorandskiy algorandskiy merged commit d44aa2d into algorand:master Mar 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature p2p Work related to the p2p project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants