Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agreement: don't attempt to make proposal if no particating accounts #4976

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 6, 2023

Summary

As described in #590 if you don't have any participation keys, you don't need to make a proposal. This adds a check to skip calling AssembleBlock() if there are no participating accounts.

Test Plan

Existing tests should pass, also need to write new test asserting AssembleBlock is not called.

@cce cce added the Enhancement label Jan 6, 2023
@cce cce requested a review from yossigi January 10, 2023 15:39
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.54%. Comparing base (a6eece5) to head (1902e59).
Report is 768 commits behind head on master.

Files with missing lines Patch % Lines
data/pools/transactionPool.go 20.00% 3 Missing and 1 partial ⚠️
agreement/pseudonode.go 0.00% 1 Missing and 1 partial ⚠️
node/node.go 0.00% 2 Missing ⚠️
data/account/participationRegistry.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4976      +/-   ##
==========================================
- Coverage   53.56%   53.54%   -0.02%     
==========================================
  Files         430      430              
  Lines       54095    54107      +12     
==========================================
- Hits        28978    28974       -4     
- Misses      22869    22884      +15     
- Partials     2248     2249       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant