Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port [Sequence] and [AnthonyNolanFilter] functionality to Python 3 #243

Closed
alexlancaster opened this issue Jan 17, 2025 · 0 comments · Fixed by #244
Closed

Port [Sequence] and [AnthonyNolanFilter] functionality to Python 3 #243

alexlancaster opened this issue Jan 17, 2025 · 0 comments · Fixed by #244
Assignees
@alexlancaster
Labels
bug Something isn't working, should not be used for new features: use "enhancement" for those

Comments

@alexlancaster
Copy link
Owner

It looks like the Python 2 -> 3 port missed out on porting the [AnthonyNolanFilter] functionality to Python 3, it is currently broken. This issue is about restoring the existing functionality and although the MSF files are very out of date - that upgrade should be handled in a separate issue.
@alexlancaster alexlancaster added the bug Something isn't working, should not be used for new features: use "enhancement" for those label Jan 17, 2025
@alexlancaster alexlancaster self-assigned this Jan 17, 2025
alexlancaster added a commit that referenced this issue Jan 18, 2025
@alexlancaster
add unit test for [Sequence] AnthonyNolan filter (#243)
e15d70c 
* move MSF files into the unit tests data area

* restore the associated .pop file and .ini file for the `sequence-nopoptests.ini`
@alexlancaster alexlancaster linked a pull request Jan 18, 2025 that will close this issue
Restore functionality for [Sequence] filters: Python 3 upgrades #244
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexlancaster alexlancaster

Labels
bug Something isn't working, should not be used for new features: use "enhancement" for those
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore functionality for [Sequence] filters: Python 3 upgrades alexlancaster/pypop
1 participant
@alexlancaster