Fix shadowed global detection to ignore declarations in type tokens #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #808 All identifier tokens, including type tokens, have a role assigned by the parser that indicates whether they're a declaration, usage, etc, and even for type tokens this is important for TS automatic export elision. When identifying shadowed globals, though, only non-type declarations should be considered. This fixes an issue where parameters within TS function types were inadvertently being treated as declarations.
Benchmark resultsBefore this PR: 319.7 thousand lines per second Measured change: 2.33% slower (4.11% slower to 0.87% slower) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #808
All identifier tokens, including type tokens, have a role assigned by the parser that indicates whether they're a declaration, usage, etc, and even for type tokens this is important for TS automatic export elision. When identifying shadowed globals, though, only non-type declarations should be considered. This fixes an issue where parameters within TS function types were inadvertently being treated as declarations.