Implement parsing for flow enums #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward #701 This is based largely off of the Babel implementation, and handles various cases with ellipses, `of` declarations, assignments, and enums as part of named and default exports. I also changed the token test to make it easier to copy and paste the error output to get a starting point for the tokens.
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 84.73% 84.83% +0.09%
==========================================
Files 54 54
Lines 5771 5801 +30
Branches 1314 1323 +9
==========================================
+ Hits 4890 4921 +31
Misses 597 597
+ Partials 284 283 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark resultsBefore this PR: 353.8 thousand lines per second Measured change: 0.03% faster (0.7% slower to 0.52% faster) |
1Lighty
pushed a commit
to Astra-mod/sucrase
that referenced
this pull request
Aug 14, 2022
Progress toward alangpierce#701 This is based largely off of the Babel implementation, and handles various cases with ellipses, `of` declarations, assignments, and enums as part of named and default exports. I also changed the token test to make it easier to copy and paste the error output to get a starting point for the tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #701
This is based largely off of the Babel implementation, and handles various cases
with ellipses,
ofdeclarations, assignments, and enums as part of named anddefault exports.
I also changed the token test to make it easier to copy and paste the error
output to get a starting point for the tokens.