Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat ! tokens as type tokens in TS variable declarations #410

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

alangpierce
Copy link
Owner

Fixes #406

@codecov-io
Copy link

Codecov Report

Merging #410 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   80.03%   80.06%   +0.02%     
==========================================
  Files          46       46              
  Lines        4958     5186     +228     
  Branches     1155     1155              
==========================================
+ Hits         3968     4152     +184     
- Misses        695      737      +42     
- Partials      295      297       +2
Impacted Files Coverage Δ
src/parser/plugins/typescript.ts 75.03% <100%> (+0.07%) ⬆️
src/util/formatTokens.ts 70.58% <0%> (-10.06%) ⬇️
src/parser/util/identifier.ts 90.9% <0%> (-4.1%) ⬇️
src/parser/plugins/jsx/index.ts 87.33% <0%> (-1.88%) ⬇️
src/parser/plugins/flow.ts 62.21% <0%> (-1.59%) ⬇️
src/util/getClassInfo.ts 85.12% <0%> (-1.21%) ⬇️
src/identifyShadowedGlobals.ts 87.8% <0%> (-1.09%) ⬇️
src/parser/traverser/statement.ts 80.46% <0%> (-0.78%) ⬇️
src/util/isIdentifier.ts 100% <0%> (ø) ⬆️
src/parser/util/whitespace.ts 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee838b9...0f378a8. Read the comment docs.

@alangpierce alangpierce merged commit 8de29dc into master Jan 20, 2019
@alangpierce alangpierce deleted the fix-definite-assignment-assertion-parsing branch January 20, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants