Fix TS import elision for JSX fragments and custom pragmas #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #395 Previously, we added the `React` identifier as non-type identifier when seeing any JSX name, but this meant that fragment syntax didn't keep that import. We also shouldn't hard-code React, and instead use whatever the pragma base values are.
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 79.95% 80.03% +0.08%
==========================================
Files 45 46 +1
Lines 5173 5184 +11
Branches 1152 1155 +3
==========================================
+ Hits 4136 4149 +13
+ Misses 738 737 -1
+ Partials 299 298 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
Previously, we added the
Reactidentifier as non-type identifier when seeingany JSX name, but this meant that fragment syntax didn't keep that import. We
also shouldn't hard-code React, and instead use whatever the pragma base values
are.