Does not support properties that must be quoted

[sudowork]

I was trying to use sucrase to transform a library that makes use of kebab-case props (e.g. aria-hidden). Sucrase produces invalid JavaScript when trying to transform that property.

Example source:

<Foo aria-hidden />

Sucrase output:

"use strict";const _jsxFileName = "sample.tsx";React.createElement(Foo, { aria-hidden: true, __self: this, __source: {fileName: _jsxFileName, lineNumber: 1}} )

The invalid output is the unquoted object property since aria-hidden is not a valid identifier.

For reference, here is the Babel output:

"use strict";

var _jsxFileName = "sample.tsx";
React.createElement(Foo, {
  "aria-hidden": true,
  __source: {
    fileName: _jsxFileName,
    lineNumber: 1
  },
  __self: void 0
});

[sudowork]

Hmm, actually ignore this... I must have been using an older version of sucrase. I just cloned this repo and added a test and it does appear to quote they property key per https://github.com/alangpierce/sucrase/blob/c77dcfe/src/transformers/JSXTransformer.ts#L101

[alangpierce]

Thanks for reporting, it looks like this actually is broken: Playground link

Looks like the quoting happens when the property has an =, but not with the shorthand property like in your original example.

[sudowork]

Ah, good call! I thought I was misremembering things for a second :).

[sudowork]

Took a shot at resolving this: #292