Fix multiple exporters issue #978
Conversation
attilakreiner
force-pushed
the
fix-exporter
branch
from
5d06017 to
dfa706b
Compare
| @@ -19,5 +19,6 @@ public interface MessageReader | |||
| { | |||
| int read( | |||
| MessageConsumer handler, | |||
| int readerId, | |||
There was a problem hiding this comment.
Prefer we not change this interface as it is following a specific design pattern.
| this.readEvent = context.supplyEventReader(); | ||
| this.formatter = context.supplyEventFormatter(); | ||
| this.out = out; | ||
| } | ||
|
|
||
| public int process() | ||
| { | ||
| return readEvent.read(this::handleEvent, 1); | ||
| return readEvent.read(this::handleEvent, stdoutExporterTypeId, 1); |
There was a problem hiding this comment.
This approach breaks if we have 2 exporter instances of the same type.
Let's instead remove the complexity of creating multiple buffer spies in the events layout requiring the change to the interface, and instead create a new spy when a new event reader is supplied. That is the signal to us that we need independent spy because we have an independent event reader, which needs to keep track of its own progress through the events.
|
|
||
| public int supplyTypeId( | ||
| String name) | ||
| { | ||
| return context.supplyTypeId(name); | ||
| } |
There was a problem hiding this comment.
We can revert this change when we create a new spy per event reader.
attilakreiner
force-pushed
the
fix-exporter
branch
from
dfa706b to
fc184f4
Compare
| @@ -110,7 +106,15 @@ private void rotateFile() | |||
| rethrowUnchecked(ex); | |||
| } | |||
| buffer = createRingBuffer(path, capacity); | |||
| bufferSpy = createRingBufferSpy(path); | |||
| accessors.forEach(a -> a.setBufferSpy(createRingBufferSpy())); | |||
There was a problem hiding this comment.
This doesn't seem like the right timing to move all the accessors to the latest rotated buffer.
It makes sense to rotate the events layout itself during write, but each event accessor would need to independently determine when they have reached the end of the current buffer and move to the next one (even if it's not the latest).
Description
This change fixes an issue, so that multiple exporters can run correctly simultaneously.