Enhance inspection of internal streams #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilakreiner
force-pushed
the
dump-poc
branch
from
b3601d3 to
ae52173
Compare
attilakreiner
changed the title
attilakreiner
force-pushed
the
dump-poc
branch
from
e614ee6 to
09ff18e
Compare
jfallows
requested changes
Dec 8, 2023
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/Bindings.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/Bindings.java
Outdated
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/Bindings.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/ConfigurationManager.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/ConfigurationManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Show resolved
Hide resolved
jfallows
requested changes
Dec 8, 2023
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Show resolved
Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/reader/BindingsLayoutReader.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Dec 8, 2023
...e/engine/src/test/java/io/aklivity/zilla/runtime/engine/config/BindingsLayoutReaderTest.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Dec 9, 2023
.../src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
Dec 9, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wireshark offers the possibility to display our own protocol format as it has support for custom dissectors written in Lua. So the idea here is to export the Zilla frames themselves into the pcap file, and write a Zilla specific Wireshark dissector in Lua. This way we could leverage Wireshark to display all the contents of the RingBuffer, examine the details of the Zilla frames, much like we can currently do with the log command, but with all the features Wireshark offers as an added benefit.
Fixes #154