Ignore appending allow origin if already present #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 17, 2025
| public void shouldIgnoreExplicitAllowOrigin() throws Exception | ||
| { | ||
| k3po.finish(); | ||
| } |
There was a problem hiding this comment.
Looks good.
We also need shouldIgnoreAllowOrigin() that uses server.access.control.cross.origin.yaml and confirms that * is not sent, otherwise we're not yet proving which value is taking precedence with only shouldIgnoreExplicitAllowOrigin().
jfallows
requested changes
Jan 17, 2025
| "${net}/ignore.explicit.allow.origin/client", | ||
| "${app}/ignore.explicit.allow.origin/server", | ||
| }) | ||
| public void shouldIgnoreAllowOriginWithNoExplicitImplicitOrigin() throws Exception |
There was a problem hiding this comment.
Suggested change
| public void shouldIgnoreAllowOriginWithNoExplicitImplicitOrigin() throws Exception | |
| public void shouldIgnoreExplicitAllowOriginWhenImplicit() throws Exception |
| "${net}/ignore.explicit.allow.origin/client", | ||
| "${app}/ignore.explicit.allow.origin/server", | ||
| }) | ||
| public void shouldIgnoreExplicitAllowOrigin() throws Exception |
There was a problem hiding this comment.
Suggested change
| public void shouldIgnoreExplicitAllowOrigin() throws Exception | |
| public void shouldIgnoreExplicitAllowOriginWhenExplicit() throws Exception |
jfallows
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.