Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed seqNr to 'revision' for all durable state APIs and implementations #30344

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Changed seqNr to 'revision' for all durable state APIs and implementations #30344

merged 1 commit into from
Jun 28, 2021

Conversation

debasishg
Copy link
Contributor

References #30277
as per this discussion on jdbc implementation

@debasishg debasishg requested review from patriknw and octonato June 28, 2021 07:37
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Jun 28, 2021
@akka-ci
Copy link

akka-ci commented Jun 28, 2021

Test PASSed.

johanandren
johanandren approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

debasishg added a commit to akka/akka-persistence-jdbc that referenced this pull request Jun 28, 2021
@debasishg
Renames state.sequence_number to state.revision - depends on PR akka/…
6e3c7c6 
…akka#30344
patriknw
patriknw approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debasishg debasishg merged commit b1f5aa8 into dev-durable-state Jun 28, 2021
@debasishg debasishg deleted the change-seqNr-to-revision branch June 28, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@johanandren johanandren johanandren approved these changes

@octonato octonato Awaiting requested review from octonato

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debasishg @akka-ci @patriknw @johanandren