udpate #12
Merged
udpate #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add editorconfig
feat: Add support for Subdomains
Now environment variables are loaded from the `app.yaml` and setable from the CLI with `--env_var KEY=VALUE`.
feat: Add support for custom environment variables
…onflicts with `viur-core`
feat: Set `--timeout` argument for gunicorn server
chore: Change pip version from exact to minimum conditions
…ds` argument working (#7) * fix: Improve and refacor entrypoint to make `--workers` and `--threads` argument working * The app_server took the entrpoint from _app.yaml_, which has mostly set this property. So the default value of `appYaml.get("entrypoint")` was actually never used. But the entrypoint in _app.yaml_ cannot have a `$WORKER` or `$THREADS` variable -- they don't exist in gcloud (https://cloud.google.com/appengine/docs/standard/python3/runtime#environment_variables) So the variables were never replaced, because they dont't exist. That made the `--worker` and `--thread` argument of the app_server useless. * Now we remove these argument always from the provides entrypoint and re-add it with the values from our argparse. This get the arguemnts working. * Furthermore I added an option to provide an custom entrypoint, if the entrypoint is set in the _app.yaml_, but should be different for the local server. Setting this through the subprocess-call in the viur-cli is a little bit tricky, but with double quoting it works. * I (and PyCharm ^^) refactored this code a bit and add some type hints. * refactor: Do some more refactorings * refactor: Do some more refactorings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.