Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French - fr translation #10

Merged
merged 7 commits into from
Dec 21, 2024
Merged

French - fr translation #10

merged 7 commits into from
Dec 21, 2024

Conversation

cyrezdev
Copy link
Contributor

French translation :)

French translation
Add fr (French)
@ImLunaHey
Copy link
Collaborator

@cyrezdev thank you. 🙏

we're about to start adding regions. would this be french french or another dialect of french like canadian french?

@cyrezdev
Copy link
Contributor Author

@ImLunaHey for region, it's fr-FR

For Canadians (fr-CA), there may be a difference (we are cousins ​​​​but do not always use the same word depending on the context)

For Belgians (fr-BE) it would be the same.

@ImLunaHey
Copy link
Collaborator

@cyrezdev gotcha. did you want to set this as fr-FR then? see #5 for more details.

@cyrezdev
Copy link
Contributor Author

@ImLunaHey How do you want it to be set?

As for en, there are en-US, en-GB, en-CA... as well.
So, is it "fr-fr": fr_fr and file name fr-fr.ts ?

@ImLunaHey
Copy link
Collaborator

ImLunaHey commented Dec 20, 2024

we'll move the english one to en-AU and then add in the others.

So, is it "fr-fr": fr_fr and file name fr-fr.ts ?

that looks correct.

Add region to fr French / France language
@cyrezdev
Copy link
Contributor Author

PR updated

@ImLunaHey ImLunaHey merged commit 5448a57 into akari-blue:main Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants