Breaking changes for Groovy 2.5, JGit 5, and JSch agent removal #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Since JGit 5 changed behavior to match C Git, this allows people to revert to the previous behavior.
To be more compatible with Java 9+. This fixes #241.
This adds an extra dependency for a potentially dubious use case, so seems worth dropping. This fixes #244
The jsch-agent project hasn't been maintained in 4 years and its been the source of many issues on the Grgit repo. We'll now leverage system SSH instead. This fixes #245.
This allows better preview in GitHub and other editors.
Old Grgit 2 options are still documented in a separate doc.
Tied to the changes of breaking this into two JARs.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a few somewhat drastic changes. They should make the library more maintainable, but it may cause some upgrade hiccups.
One issue to still research is whether we can prevent SSH from blocking when you don't have either a password-free SSH key or one loaded into your system agent.