Change channel priority sort #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue ajacksified#15 where a subscriber with an initial priority of 9 winds up being called after a subscriber with priority 1 which was later added. Instead of manually splicing the subscriber into the array of subscribers the `addSubscriber` and `setPriority` and changing the value of the priority property, subscribers are now sorted using the `sort` function of the array with a custom compare function. This compare function will sort the subscribers based on their `priority` property on the `options` object in descending order. The custom sort method doesn't not manipulate the value of the priorityproperty giving a much more predictable result. The unit tests for the priorities have been update to better test if the sort works as expected. An additional unit test specifically for issue ajacksified#15 has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #15 where a subscriber with an initial priority of 9
winds up being called after a subscriber with priority 1 which was later
added.
Instead of manually splicing the subscriber into the array of
subscribers the
addSubscriberandsetPriorityand changing the valueof the priority property, subscribers are now sorted using the
sortfunction of the array with a custom compare function.
This compare function will sort the subscribers based on their
priorityproperty on the
optionsobject in descending order. The custom sortmethod doesn't not manipulate the value of the priorityproperty giving a
much more predictable result.
The unit tests for the priorities have been update to better test if the
sort works as expected. An additional unit test specifically for
issue #15 has been added.