Fix: prevent scroll to reset not working #291
Merged
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! The test failure looks unrelated to this PR so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #290,
preventScrollResetnot working because it's not passing the option to the submitter/fetcherthis pull requests proxies the
preventScrollResetandrelativeprops to the submitter/fetcher (I found outrelativeis not proxied either so I added that to the opt variable as well)Other Notes
@remixpackages to a newer version sincepreventScrollResetwasn't available at that versionapps/sample-appit seems there is a linking issue between packagesso please before merging this PR test it (if any changes are needed just push your changes - no need to ask)
Closes #290